Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Added pytest flags to setup.cfg #2535

Merged
merged 11 commits into from
May 29, 2022
Merged

[MNT] Added pytest flags to setup.cfg #2535

merged 11 commits into from
May 29, 2022

Conversation

aiwalter
Copy link
Contributor

@aiwalter aiwalter commented Apr 23, 2022 •
edited
Loading

What does this implement/fix?

Consolidation of pytest flags

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [DOC] or [BUG] indicating whether the PR topic is related to enhancement, documentation or bug
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@aiwalter aiwalter changed the title Added pytest flags to setup.cfg [MNT] Added pytest flags to setup.cfg Apr 23, 2022
aiwalter
aiwalter commented Apr 23, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@aiwalter
Copy link
Contributor Author

@lmmentel @freddyaboulton could you two as our CI/CD experts pls have a look? 🙂

aiwalter
aiwalter commented Apr 24, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@aiwalter aiwalter marked this pull request as ready for review April 24, 2022 00:57
@aiwalter aiwalter added the maintenance Continuous integration, unit testing & package distribution label Apr 24, 2022
@aiwalter
Copy link
Contributor Author

aiwalter commented Apr 24, 2022 •
edited
Loading

for some reason when I edit the build_wheels.sh file to do the changes there as well, I get a pre-commit failure of the shellcheck. It is unrelated to my changes and just triggers bcz I changed sth in the file. I skipped pre-commit now for that file.

@lmmentel
Copy link
Contributor

lmmentel commented May 1, 2022

Great work, how about moving the configuration into pyproject.toml? setup.py is being flagged as legacy packaging backend so we might as well move the configuration.

lmmentel
lmmentel reviewed May 1, 2022
View reviewed changes
setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@aiwalter
Copy link
Contributor Author

aiwalter commented May 1, 2022

I think deprecating setup.cfg can be done in a separate PR.

@aiwalter aiwalter closed this May 1, 2022
@aiwalter aiwalter reopened this May 1, 2022
fkiraly
fkiraly approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for consolidating this!

@lmmentel, are you fine with this?

@lmmentel lmmentel self-requested a review May 18, 2022 21:30
fkiraly
fkiraly reviewed May 18, 2022
View reviewed changes
setup.cfg Show resolved Hide resolved
@fkiraly fkiraly merged commit 6906f80 into sktime:main May 29, 2022
@chrisholder chrisholder mentioned this pull request Jul 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@lmmentel lmmentel lmmentel approved these changes

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiwalter @lmmentel @fkiraly