-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to PyTorch 1.11.0 #846
Conversation
- Drop 1.7.1 - Update 1.10.0/1.10.1 to 1.10.2 Moreover, change all pip install instructions from 'pip install' to 'python -m pip install', which is the recommended way.
Looking at the release notes, I don't see any necessary changes on the skorch side. We should possibly take a look at the new TorchData to see if there is anything required on the skorch side to support it or facilitate its use. |
Hmm, not sure why we get this error:
1.11.0 for CPU seems to be listed on https://download.pytorch.org/whl/torch_stable.html :/ |
Try to narrow down cause.
Looking through the METADATA of the wheel, |
Remove obsolete exclusion as well.
Yes, that was it, thanks! |
@thomasjpfan Is this ready to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Moreover, change all pip install instructions from
pip install
topython -m pip install
, which is the recommended way.