Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PyTorch 1.11.0 #846

Merged
merged 5 commits into from
Apr 24, 2022
Merged

Conversation

BenjaminBossan
Copy link
Collaborator

  • Drop 1.7.1
  • Update 1.10.0/1.10.1 to 1.10.2

Moreover, change all pip install instructions from pip install to
python -m pip install, which is the recommended way.

- Drop 1.7.1
- Update 1.10.0/1.10.1 to 1.10.2

Moreover, change all pip install instructions from 'pip install' to
'python -m pip install', which is the recommended way.
@BenjaminBossan BenjaminBossan self-assigned this Mar 20, 2022
@BenjaminBossan
Copy link
Collaborator Author

Looking at the release notes, I don't see any necessary changes on the skorch side.

We should possibly take a look at the new TorchData to see if there is anything required on the skorch side to support it or facilitate its use.

@BenjaminBossan
Copy link
Collaborator Author

Hmm, not sure why we get this error:

ERROR: Could not find a version that satisfies the requirement torch==1.11.0+cpu

1.11.0 for CPU seems to be listed on https://download.pytorch.org/whl/torch_stable.html :/

@thomasjpfan
Copy link
Member

1.11.0 for CPU seems to be listed on https://download.pytorch.org/whl/torch_stable.html :/

Looking through the METADATA of the wheel, 1.11.0 does not support Python 3.6

Remove obsolete exclusion as well.
@BenjaminBossan
Copy link
Collaborator Author

Looking through the METADATA of the wheel, 1.11.0 does not support Python 3.6

Yes, that was it, thanks!

@BenjaminBossan
Copy link
Collaborator Author

@thomasjpfan Is this ready to be merged?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit fe71e3d into master Apr 24, 2022
@thomasjpfan thomasjpfan deleted the pytorch-1.11.0-and-pip-instructions branch April 24, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants