Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: python and pytorch versions updated #733

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Maintenance: python and pytorch versions updated #733

merged 3 commits into from
Dec 23, 2020

Conversation

BenjaminBossan
Copy link
Collaborator

Supersedes #686

  • use github actions instead of travis
  • add CI for PyTorch 1.4.0 (since we want to support 4 versions)
  • check PyTorch 1.7.1 instead of 1.7.0
  • update docs
  • remove warning about Python 3.5 support
  • remove warning about change in CyclicLR step being per epoch

BenjaminBossan added 3 commits December 22, 2020 13:26
Update and document supported PyTorch versions
80e3765 
- add 1.4.0 since we want to support 4 versions
- use 1.7.1 instead of 1.7.0
- update documentation
Remove warning abt Python 3.5 support being dropped
d1d9da7
Remove warning about CyclicLR step on epoch
952b89d
@BenjaminBossan BenjaminBossan self-assigned this Dec 22, 2020
@BenjaminBossan BenjaminBossan mentioned this pull request Dec 22, 2020
Closed
thomasjpfan
thomasjpfan approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenjaminBossan BenjaminBossan merged commit ddf6247 into master Dec 23, 2020
@BenjaminBossan BenjaminBossan deleted the maint-python-pytorch-versions-update branch March 23, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@ottonemo ottonemo Awaiting requested review from ottonemo

Assignees

@BenjaminBossan BenjaminBossan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminBossan @thomasjpfan