Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from .scoring imports #575

Merged
merged 4 commits into from
Feb 14, 2020
Merged

Conversation

ottonemo
Copy link
Member

As reported in #573.

@BenjaminBossan
Copy link
Collaborator

I think we should agree on a solution for #579 first (i.e. whether to use LooseVersion or packaging.version.

@ottonemo
Copy link
Member Author

@BenjaminBossan Please review again, changed to LooseVersion.

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the minor comment, rest LGTM

skorch/callbacks/scoring.py Show resolved Hide resolved
@ottonemo
Copy link
Member Author

@BenjaminBossan done

@BenjaminBossan BenjaminBossan merged commit b7606bd into master Feb 14, 2020
sthagen added a commit to sthagen/skorch-dev-skorch that referenced this pull request Feb 15, 2020
Move away from .scoring imports (skorch-dev#575)
@BenjaminBossan BenjaminBossan deleted the issue/sklearn-scorer branch July 30, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants