Fix #strip_diff_colors output for CircleCI #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @qbart, thanks for the contribution! Could you please add a failing test case demonstrating the issue? |
|
Please try upgrading to the latest version: https://rubygems.org/gems/rspec_junit_formatter/versions/0.4.0 |
|
sure, after the upgrade i will add missing test scenario |
|
FWIW, I've addressed this as follows - run:
name: "Strip ANSI codes"
command: sed -i -E 's/\\e\[[0-9;]+m//g' tmp/rspec/*.xml
when: always |
|
Ah, I see the problem — CodeRay does sometimes use multiple tags in the same ansi code. I'll merge this and tweak! |
|
Released in v0.4.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
small regex improvement for stripping out colored text, you can see how it works before and after the change:
before:
after:
hope that helps