-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for oidc #389
Add support for oidc #389
Conversation
This configuration worked for my Authentik provider: LD_ENABLE_OIDC=True
OIDC_RP_SIGN_ALGO=HS256
OIDC_OP_JWKS_ENDPOINT=https://auth.example.org/application/o/linkding/jwks/
OIDC_OP_AUTHORIZATION_ENDPOINT=https://auth.example.org/application/o/authorize/
OIDC_OP_TOKEN_ENDPOINT=https://auth.example.org/application/o/token/
OIDC_OP_USER_ENDPOINT=https://auth.example.org/application/o/userinfo/
OIDC_RP_CLIENT_ID=XXXXXX
OIDC_RP_CLIENT_SECRET=YYYYYY The "change password" link is still visible after a OIDC login, should it be removed in this case? |
Allowing pw change for users logged in with oidc does seem unintuitive, I will take another look at this sometime soon-ish |
In the shared bookmark page, I see a gibberish user name when I filter per user. |
That seems viable. I'll make sure to look into this, thanks a lot for your review! Disclaimer: I'll only have time to take care of the issues in about 3 weeks. |
I'd love to see this merged. is it possible ? |
I've been on vacation since march and didn't have time to look into the issues brought up. I might have some time to clean this up in the next couple days or at the very latest in September... So until its cleaned up probably not ready to merge |
Hi!,I'm very interested in this feature, any news? |
I made a modified version of the patch that doesn't have the conflicts with the current version but am currently getting a 500 error, the stack trace below:
... any ideas? Would love to get this working to have one more app in my arsenal locked behind Authentik ':D |
Todo:
|
|
I think this is ready for review |
# Conflicts: # bookmarks/views/settings.py # requirements.prod.txt # requirements.txt # siteroot/settings/base.py # siteroot/urls.py
Taking a look at this now, will rebase and push some changes shortly. |
Made some changes:
A basic configuration for Zitadel should now look something like this, assuming that PKCE is used:
|
This also make sense for header based authentication. |
These changes add support for OIDC authentication using mozilla-django-oidc
Fixes #177
While this isn't merged, there is an image at https://hub.docker.com/r/nighmared/linkding-oidc :)