Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sirupsen/logrus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.9.0
Choose a base ref
...
head repository: sirupsen/logrus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.9.3
Choose a head ref
  • 13 commits
  • 6 files changed
  • 6 contributors

Commits on Jun 16, 2022

  1. Configuration menu
    Copy the full SHA
    d8787af View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Fix data race in hooks.test package

    Francois committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    ff07b25 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Merge pull request #1362 from FrancoisWagner/fix-data-race-in-hooks-t…

    …est-pkg
    
    Fix data race in hooks.test package
    sirupsen authored Jan 7, 2023
    Configuration menu
    Copy the full SHA
    a448f82 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Add instructions to use different log levels for local and syslog

    This commit adds instructions to the syslog readme about how to
    send different log levels to local logging (`log.SetLevel`) and
    syslog hook.
    
    fixes #1369
    tommyblue committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    70234da View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. This commit fixes a potential denial of service vulnerability in logr…

    …us.Writer() that could be triggered by logging text longer than 64kb without newlines. Previously, the bufio.Scanner used by Writer() would hang indefinitely when reading such text without newlines, causing the application to become unresponsive.
    ozfive committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    766cfec View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. Configuration menu
    Copy the full SHA
    e59b167 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Scan text in 64KB chunks

    This commit fixes a potential denial of service
    vulnerability in logrus.Writer() that could be
    triggered by logging text longer than 64KB
    without newlines. Previously, the bufio.Scanner
    used by Writer() would hang indefinitely when
    reading such text without newlines, causing the
    application to become unresponsive.
    ozfive authored and ashmckenzie committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c052ba6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from ashmckenzie/ashmckenzie/fix-writer-scanner

    Scan text in 64KB chunks
    ozfive authored May 4, 2023
    Configuration menu
    Copy the full SHA
    105e63f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Merge pull request #1376 from ozfive/master

    This commit fixes a potential denial of service vulnerability in logrus.Writer() that could be triggered by logging text longer than 64kb without newlines.
    sirupsen authored May 15, 2023
    Configuration menu
    Copy the full SHA
    6acd903 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1339 from xieyuschen/patch-1

    Use text when shows the logrus output
    sirupsen authored May 15, 2023
    Configuration menu
    Copy the full SHA
    b30aa27 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Revert "Merge pull request #1376 from ozfive/master"

    This reverts commit 6acd903, reversing
    changes made to e59b167.
    sirupsen committed May 17, 2023
    Configuration menu
    Copy the full SHA
    352781d View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Revert "Revert "Merge pull request #1376 from ozfive/master""

    This reverts commit 352781d.
    sirupsen committed May 21, 2023
    Configuration menu
    Copy the full SHA
    f9291a5 View commit details
    Browse the repository at this point in the history
  2. fix panic in Writer

    Commit 766cfec introduced this bug by defining an incorrect split
    function. First it breaks the old behavior because it never splits at
    newlines now. Second, it causes a panic because it never tells the
    scanner to stop. See the bufio.ScanLines function, something like:
    ```
    if atEOF && len(data) == 0 {
    	return 0, nil, nil
    }
    ```
    is needed to do that.
    
    This commit fixes it by restoring the old behavior and calling
    bufio.ScanLines but also keep the 64KB check in place to avoid buffering
    for to long.
    
    Two tests are added to ensure it is working as expected.
    
    Fixes #1383
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 authored and sirupsen committed May 21, 2023
    Configuration menu
    Copy the full SHA
    d40e25c View commit details
    Browse the repository at this point in the history
Loading