Upgrade to latest config from webpack-dev-server v4.0.0-rc.0 #310
Conversation
🦋 Changeset detectedLatest commit: a31d474 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Thanks for your help in reporting the issue, identifying the cause, and contributing a fix. I've pushed a couple commits to this PR to fix up the following:
- The version of webpack-dev-server in newly generated package.jsons should be 4.0.0-rc.0
- The client.host property was renamed to client.webSocketURL.hostname - it was not removed. It's important because otherwise the web socket connectino from the browser to webpack-dev-server will not work since it will make the request relative to the html page (root config) rather than the microfrontend's webpack-dev-server.
I also agree this is a breaking change and will publish it as a new major for webpack-config-single-spa
| @@ -85,15 +85,16 @@ function webpackConfigSingleSpa(opts) { | |||
| }, | |||
| devtool: "source-map", | |||
| devServer: { | |||
| compress: true, | |||
There was a problem hiding this comment.
I confirmed that this is the new default value in webpack-dev-server and that gzip compression still occurs with this change.
|
Released in webpack-config-single-spa@4.0.0. See https://github.com/single-spa/create-single-spa/blob/main/packages/webpack-config-single-spa/CHANGELOG.md#400 for migration instructions |
|
Thanks for tidying this up! Haven't worked with
Ah, of course. I couldn't figure out where it went and thought this might have been superseded by |
Yeah I wasn't sure if |
Resolves #309
I'm guessing this would be considered a major release given it'd break for anyone who might still be using
webpack-dev-serverv3.x.x (or anyone who's pinned to a beta release ofwebpack-dev-serverv4.0.0-beta(x).Happy to make any changes, just thought I'd kick off a PR to hopefully save some time in getting this fixed :)