Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate identical file patterns #57

Closed
sindresorhus opened this issue Nov 19, 2017 · 2 comments
Closed

Deduplicate identical file patterns #57

sindresorhus opened this issue Nov 19, 2017 · 2 comments
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Nov 19, 2017 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

I think this stopped working with cf55e5c.

This

globby/index.js

Line 84 in 1c01091

.then(tasks => arrayUnion.apply(null, tasks));
doesn't work as it's an object, not simple patterns, and here

globby/index.js

Lines 113 to 117 in 9bf9983

const newTask = getPattern(task, dirGlob.sync).map(glob => ({
pattern: glob,
opts: task.opts
}));
return tasks.concat(newTask);
I had to remove the logic to fix #54.

We probably have to use deep equality or improve the handling some other way. The readability of the code could also be improved.

// @kevva

kevva earned $40.00 by resolving this issue!
@IssueHuntBot
Copy link

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt

kevva added a commit that referenced this issue Jan 11, 2019
@kevva
Deduplicate identical file patterns
257cf19 
Fixes #57.
@kevva kevva mentioned this issue Jan 11, 2019
Merged
sindresorhus pushed a commit that referenced this issue Feb 15, 2019
@kevva @sindresorhus
Deduplicate identical file patterns (#102)
2294618 
Fixes #57
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @kevva. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @IssueHuntBot