-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9 not throwing ENOTDIR when cwd is a file #105
Comments
Would you be able to submit those tests as failing tests? That would help getting this fixed faster. |
@IssueHunt has funded $20.00 to this issue. See it on IssueHunt |
This is caused by an update to 2.0.0 const getPath = filepath => filepath[0] === '!' ? filepath.slice(1) : filepath; 2.2.1 const getPath = (filepath, cwd) => path.join(cwd, filepath[0] === '!' ? filepath.slice(1) : filepath); @sindresorhus What should we do? Remove the failing tests? |
Add a check to ensure |
@sindresorhus has rewarded $18.00 to @medusalix. See it on IssueHunt
|
This might be expected, but when using
'.'
as the pattern and specifyingcwd
as a file, an error is no longer thrown inv9
like it was inv8
.passing: chrisblossom/globby/v8-is-file/test.js#L199-L221
failing: chrisblossom/globby/v9-is-file/test.js#L218-L241
The text was updated successfully, but these errors were encountered: