Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R Learning #1882

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Add R Learning #1882

merged 2 commits into from
Oct 28, 2020

Conversation

iamericfletcher
Copy link
Contributor

@iamericfletcher iamericfletcher commented Oct 13, 2020

Original PR #1837 was orphaned by mistake. This PR replaces it.

https://github.com/iamericfletcher/awesome-r-learning-resources#readme

This list is a collection of resources related to R, a programming language and environment for statistical computing and graphics. It is meant to help users from all skill levels and backgrounds deepen their understanding of R, resulting in a more knowledgable programming population that benefits everybody involved.

Reviewed PRs: #1857 #1848

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@iamericfletcher
Copy link
Contributor Author

unicorn.

@iamericfletcher
Copy link
Contributor Author

Awesome-lint results:

awesome-r-learning-resources_—-bash—_272×76

@sindresorhus sindresorhus changed the title Add R Learning Resources Add R Learning Oct 13, 2020
@sindresorhus
Copy link
Owner

From the math et al YoutTube channel.

Typo. Ensure all descriptions are typo-free and well written.


The header image is way too small and it repeats the header title. So it drop the text from the graphic or replace the header title with it.


Drop the pull request and last commit badges. The GitHub UI already shows this info.

@iamericfletcher
Copy link
Contributor Author

Hi @sindresorhus:

  • The YouTube channel that created that particular video is named math et al link to channel.

Et al. comes from the Latin phrase meaning “and others.” It is usually styled with a period, but you will occasionally see et al as well. Merriam-Webster

  • I have replaced the header title with the image.

  • I have dropped the pull request and last commit badges.

https://github.com/iamericfletcher/awesome-r-learning-resources

@sindresorhus
Copy link
Owner

The YouTube channel that created that particular video is named math et al link to channel.

That's not the typo. But I would also quote the name to make it clearer.

@sindresorhus
Copy link
Owner

The header image has too low resolution. See the guidelines.

@iamericfletcher
Copy link
Contributor Author

iamericfletcher commented Oct 13, 2020

@sindresorhus Ack! Apologies for the oversight on my part. YoutTube is now YoutTube and I have quoted the name.

I opened the image in Preview and changed the resolution to 500. If I were to set it to maximum half the width of the original image, the resolution would be even lower.

github_logo_png

@iamericfletcher
Copy link
Contributor Author

iamericfletcher commented Oct 14, 2020

I decided to ditch the old logo and make a new one that I believe will satisfy the high-dpi requirement. It still features the owl with academic cap. I think it looks better than the old one, so that's a plus! :) Thanks @sindresorhus for taking the time to review my list and help me out. It means a lot. I am very grateful.

logo

Have a good night! - Eric

@chrisdiana
Copy link

chrisdiana commented Oct 17, 2020

@iamericfletcher please run awesome lint on your changes. The error on line 56 (Viz > Chart Suggestions) should be fixed.

  readme.md:92:156
  ✖   1:1    Missing main list heading                                     remark-lint:awesome-heading
  ✖  56:156  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  92:156  "’" is used without matching "‘"                              remark-lint:match-punctuation

  3 errors

Error on line 92 seems OK since it's used in this context:

Thomas Lin Pedersen is a data scientist turned software engineer who focuses on improving researchers’ interactions with the data they produce.

@iamericfletcher
Copy link
Contributor Author

@iamericfletcher please run awesome lint on your changes. The error on line 56 (Viz > Chart Suggestions) should be fixed.

  readme.md:92:156
  ✖   1:1    Missing main list heading                                     remark-lint:awesome-heading
  ✖  56:156  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  92:156  "’" is used without matching "‘"                              remark-lint:match-punctuation

  3 errors

Error on line 92 seems OK since it's used in this context:

Thomas Lin Pedersen is a data scientist turned software engineer who focuses on improving researchers’ interactions with the data they produce.

Thank you @chrisdiana - I have replaced the . with a -.

@iamericfletcher
Copy link
Contributor Author

@sindresorhus - Can I please request another review?

@sindresorhus
Copy link
Owner

  • Linkify R in R is a programming language and environment to its official website.
  • I think the header illustration should use the same blur shade as the R logo.
  • You should link to the main R list in a "Related" section at the bottom.

@sindresorhus sindresorhus merged commit 1a3ee40 into sindresorhus:main Oct 28, 2020
@sindresorhus
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants