-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R Learning #1882
Add R Learning #1882
Conversation
unicorn. |
Typo. Ensure all descriptions are typo-free and well written. The header image is way too small and it repeats the header title. So it drop the text from the graphic or replace the header title with it. Drop the pull request and last commit badges. The GitHub UI already shows this info. |
Hi @sindresorhus:
https://github.com/iamericfletcher/awesome-r-learning-resources |
That's not the typo. But I would also quote the name to make it clearer. |
The header image has too low resolution. See the guidelines. |
@sindresorhus Ack! Apologies for the oversight on my part. I opened the image in Preview and changed the resolution to 500. If I were to set it to maximum half the width of the original image, the resolution would be even lower. |
I decided to ditch the old logo and make a new one that I believe will satisfy the high-dpi requirement. It still features the owl with academic cap. I think it looks better than the old one, so that's a plus! :) Thanks @sindresorhus for taking the time to review my list and help me out. It means a lot. I am very grateful. Have a good night! - Eric |
@iamericfletcher please run awesome lint on your changes. The error on line 56 (Viz > Chart Suggestions) should be fixed.
Error on line 92 seems OK since it's used in this context:
|
Thank you @chrisdiana - I have replaced the |
@sindresorhus - Can I please request another review? |
|
Original PR #1837 was orphaned by mistake. This PR replaces it.
https://github.com/iamericfletcher/awesome-r-learning-resources#readme
This list is a collection of resources related to R, a programming language and environment for statistical computing and graphics. It is meant to help users from all skill levels and backgrounds deepen their understanding of R, resulting in a more knowledgable programming population that benefits everybody involved.
Reviewed PRs: #1857 #1848
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.