-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TensorFlow.js #1766
Add TensorFlow.js #1766
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@sindresorhus I fixed everything and completed everything on the checklist. Thanks! :) 👍 |
@aaronhma Change title from Add Awesome TensorFlow.js to Add TensorFlow.js as per the guidelines. |
@uppusaikiran Thanks! I have already updated it. |
@sindresorhus Can you please approve of this PR? Thanks! :) |
The
I think the repo name should be You cannot just copy https://github.com/aaronhma/awesome-tensorflow-tfjs/blob/master/CONTRIBUTING.md from Awesome. It needs to be adapted to your list. See other Awesome list for inspiration.
|
Done. Removed section header, and moved about section below the title.
Done. Created a new and updated Table of Contents separated by categories.
Done. Rename the repo to awesome-tensorflow-js
Done. The contribution guide is fully updated with detailed descriptive instruction. Done. Lint free used awesome-lint to lint the list. @sindresorhus Please, re-review! Thank you very much for your detailed instruction and it helps me a lot as a first-timer contributor! |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
https://github.com/aaronhma/awesome-tensorflow-js
About
This repository contains a curated list of dedicated resources to help you become a ninja at TensorFlow.js.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.