Add descriptions for entries #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Nov 1, 2017
readme.md
Outdated
| @@ -202,7 +202,7 @@ | |||
| - [Material Design](https://github.com/sachin1092/awesome-material) | |||
| - [D3](https://github.com/wbkd/awesome-d3) - Library for producing dynamic, interactive data visualizations. | |||
| - [Emails](https://github.com/jonathandion/awesome-emails) | |||
| - [jQuery](https://github.com/petk/awesome-jquery) | |||
| - [jQuery](https://github.com/petk/awesome-jquery) - JavaScript library designed for ease of use. | |||
There was a problem hiding this comment.
This description is too generic. It should describe what jQuery is.
sindresorhus
reviewed
Nov 1, 2017
readme.md
Outdated
| @@ -373,7 +373,7 @@ | |||
| - [Science Fiction](https://github.com/sindresorhus/awesome-scifi) - Scifi. | |||
| - [Fantasy](https://github.com/RichardLitt/awesome-fantasy) | |||
| - [Podcasts](https://github.com/guipdutra/awesome-geek-podcasts) | |||
| - [Email Newsletters](https://github.com/vredniy/awesome-newsletters) | |||
| - [Email Newsletters](https://github.com/vredniy/awesome-newsletters) | |||
There was a problem hiding this comment.
Sorry, that was a mistake.
sindresorhus
reviewed
Nov 1, 2017
readme.md
Outdated
| @@ -487,7 +487,7 @@ | |||
|
|
|||
| ## Miscellaneous | |||
|
|
|||
| - [JSON](https://github.com/burningtree/awesome-json) | |||
| - [JSON](https://github.com/burningtree/awesome-json) - Object notation system. | |||
There was a problem hiding this comment.
This description needs to be more specific. It doesn't really explain anything.
|
Looks good now. Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds descriptions for 11 entries in the list. Helps with #928.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.