This repository has been archived by the owner on May 16, 2021. It is now read-only.
Add Sinatra::Runner For Managing Sinatra Servers #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module Sinatra | ||
| class Runner | ||
| def app_file | ||
| File.expand_path("../server.rb", __FILE__) |
There was a problem hiding this comment.
It is, by overriding this method.
|
No tests. :( |
| end | ||
|
|
||
| def run | ||
| #puts command |
|
We'll look into this for Sinatra 1.5 |
|
@apotonick Find a way to make it configurable, remove the |
|
Ok, I'm going to merge this, even without the configure option (since there is a workaround) and tests. It's a new feature, that I will mark as experimental, so I'm fine if we add them later. |
zzak
pushed a commit
to zzak/sinatra-contrib
that referenced
this pull request
Jul 22, 2016
Add Sinatra::Runner For Managing Sinatra Servers
myabc
added a commit
to myabc/roar
that referenced
this pull request
Dec 9, 2016
sinatra/sinatra-contrib#122 has been merged. Closes trailblazer#195. Signed-off-by: Alex Coles <alex@alexbcoles.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extremely useful e.g. if you wanna test your REST client against a real backend (with real network calls). Assuming the test backend is a sinatra app, this class helps you to start and stop the server in your test.