Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation in French about multi-threading. #997

Merged
merged 1 commit into from
May 23, 2015
Merged

Conversation

kytrinyx
Copy link
Contributor

I made an attempt at adding documentation about using Sinatra in multi-threaded mode, however my French is conversational, not technical, and I expect that I have made numerous typos, as well as missing the mark on technical expressions. See #941

/cc @karouf @michelc @robin850 Would you mind suggesting improvements before this gets merged?

@@ -2808,6 +2809,41 @@ Avec les options :
-x # active le mutex lock (off par défaut)
```

### Multi-threading

_Cette partie est basée sur [une réponse StackOverflow][so-answer] par Konstantin._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/par/de

@robin850
Copy link
Contributor

Nice work @kytrinyx, thanks for working on that!

@karouf
Copy link
Contributor

karouf commented Apr 10, 2015

Yes overall it's pretty good.

@kytrinyx
Copy link
Contributor Author

Thanks for the feedback! I'll get this cleaned up tonight.

@kytrinyx kytrinyx force-pushed the fr-multi-threaded branch from 5681f8c to 7f8259d Compare April 11, 2015 20:06
@kytrinyx
Copy link
Contributor Author

I've cleaned this up. Would you give it one last sanity check?


_Cette partie est basée sur [une réponse StackOverflow][so-answer] de Konstantin._

Sinatra n'impose pas de modèle de concurrance. Sinatra est thread-safe, vous pouvez
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/concurrance/concurrence, otherwise everything seems good to me! 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The "comme ça se prononce" thing throws me every time :)

@kytrinyx kytrinyx force-pushed the fr-multi-threaded branch from 7f8259d to 95d6c14 Compare April 12, 2015 02:33
@zzak
Copy link
Member

zzak commented May 23, 2015

Great work @kytrinyx!

zzak pushed a commit that referenced this pull request May 23, 2015
Add documentation in French about multi-threading.
@zzak zzak merged commit 8056ae7 into master May 23, 2015
@zzak zzak deleted the fr-multi-threaded branch May 23, 2015 01:09
zzak pushed a commit that referenced this pull request Sep 11, 2015
Add documentation in French about multi-threading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants