Rack 3.1 compatibility #2035
Merged
Rack 3.1 compatibility #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Rack 3.0 for most jobs for now. Not sure why some jobs was allowed to fail, try without that.
More details in sinatra#2027
Rack::Logger was removed in Rack 3.2. Close sinatra#2018 Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
The class name changed in rack/rack@3936b90 We have been here before, for example with sinatra@1dfae3d This was hidden until Rack 3.1, from Samuel Williams[1]: > It was being inadvertently added back in by Response#buffered_body! > (invoked by MockResponse#initialize). In other words, it appears that > the test is wrong, or Sinatra's code is wrong, and this wrongness was > hidden by the previous implementation of MockResponse inadvertently > adding the content-length header when none existed in the response > itself. 1: rack/rack#2219 (comment)
We got that Rack release we needed (3.1.7). Close sinatra#2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
StaticTest#test_handles_valid_byte_ranges_correctly_0fails with Rack 3.1 #2019Rack::Logger is deprecated and will be removed in Rack 3.2#2018Rack::Protection::CookieTossingtest fail with Rack 3.1.3 #2017Close #2019
Close #2017
Close #2018
Close #2014
Close #2029 (cherry-picked to this branch)