Fix compatibility with --enable-frozen-string-literal
#2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
Jul 11, 2024
| @@ -48,7 +48,7 @@ gem 'rdiscount', platforms: [:ruby] | |||
| gem 'rdoc' | |||
| gem 'redcarpet', platforms: [:ruby] | |||
| gem 'simplecov', require: false | |||
| gem 'slim', '~> 4' | |||
| gem 'slim', '~> 5' | |||
There was a problem hiding this comment.
Yeah, I had to upgrade otherwise it was blocking upgrading tilt to 2.2.0 which is needed for this.
dentarg
force-pushed
the
frozen-string-literal-compat
branch
from
3b1604a to
49f319b
Compare
|
Are you up for fixing sinatra-contrib too? :) |
Ever since Ruby 2.3 it has been possible to enable frozen string literals globally via `RUBYOPT`, and it is scheduled to be the default in Ruby 4.
casperisfine
force-pushed
the
frozen-string-literal-compat
branch
from
49f319b to
f06e2d0
Compare
Didn't know it was a thing. Should pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since Ruby 2.3 it has been possible to enable frozen string literals globally via
RUBYOPT, and it is scheduled to be the default in Ruby 4.