Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare missing dependencies for Ruby 3.5 #2032

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Declare missing dependencies for Ruby 3.5 #2032

merged 2 commits into from
Jul 11, 2024

Conversation

casperisfine
Copy link
Contributor 

rack-protection/lib/rack/protection/base.rb:6: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.
test/rabl_test.rb:5: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec.

@ioquatix
Copy link
Contributor

LGTM, note that we are also adding logger dependency in https://github.com/sinatra/sinatra/pull/2029/files

byroot and others added 2 commits July 11, 2024 14:36
@byroot @dentarg
Declare missing dependencies for Ruby 3.5
46cff03 
```
rack-protection/lib/rack/protection/base.rb:6: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.
test/rabl_test.rb:5: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec.
```
@dentarg
Dependencies lists are sorted
41dfde5
@dentarg dentarg force-pushed the ruby-3.5-dependencies branch from 4b2dc45 to 41dfde5 Compare July 11, 2024 12:38
@dentarg
Copy link
Member

dentarg commented Jul 11, 2024

LGTM, note that we are also adding logger dependency in https://github.com/sinatra/sinatra/pull/2029/files

That was for sinatra, we need it in rack-protection too, as it can be used without Sinatra

@dentarg dentarg merged commit 319af3a into sinatra:main Jul 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@casperisfine @ioquatix @dentarg @byroot