Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning about Hash construction. #2028

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix warning about Hash construction. #2028

merged 1 commit into from
Jul 11, 2024

Conversation

ioquatix
Copy link
Contributor

@ioquatix ioquatix commented Jul 11, 2024 •
edited
Loading

Fixes #2026.

sinatra/test/indifferent_hash_test.rb:29: warning: Calling Hash.new with keyword arguments is deprecated and will be removed in Ruby 3.4; use Hash.new({ key: value }) instead

@ioquatix ioquatix mentioned this pull request Jul 11, 2024
Merged
@dentarg
Copy link
Member

dentarg commented Jul 11, 2024

Thanks, I missed this warning. We can see it in CI at https://github.com/sinatra/sinatra/actions/runs/9881897571/job/27293644715#step:5:19

@dentarg dentarg merged commit 4def0aa into sinatra:main Jul 11, 2024
25 checks passed
@ioquatix ioquatix deleted the hash-arguments branch July 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test TestIndifferentHashBasics#test_default_object fails in ruby-head
2 participants
@ioquatix @dentarg