feature: add except to IndifferntHash
#1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added in Ruby 3.0 so it would be nice that calling except in a `Sinatra::IndifferntHash` supported the indifferent access that the latter provides – right now, calling `except(:a)` on `Sinatra::IndifferntHash[a: :a]` would not filter the `a` key. This commits adds indifferent access support to except so that it will exclude the passed key independently if the key is passed as a `String` or `Symbol`.
santiagorodriguez96
changed the title
Hash#exceptexcept to IndifferntHash
epergo
requested changes
Aug 21, 2023
Co-authored-by: Eloy Pérez <ej.perezgomez@gmail.com>
olleolleolle
approved these changes
Aug 22, 2023
epergo
approved these changes
Aug 22, 2023
santiagorodriguez96
deleted the
add-indifferent-access-support-for-except
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
Hash#exceptwas added in Ruby 3.0 so it would be nice that callingexceptin aSinatra::IndifferntHashsupported the indifferent access that the latter provides – right now, callingexcept(:a)onSinatra::IndifferntHash[a: :a]would not filter theakey.This commits adds indifferent access support to except so that it will exclude the passed key independently if the key is passed as a
StringorSymbol.