Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.6 release #1893

Merged
merged 1 commit into from
Apr 11, 2023
Merged

3.0.6 release #1893

merged 1 commit into from
Apr 11, 2023

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Mar 4, 2023 •
edited
Loading

v3.0.5...v3.0.6

WDYT @sinatra/sinatras-helpers ?

Close #1882

@dentarg
Copy link
Member Author

dentarg commented Mar 4, 2023

Or should it be 3.0.6? Not sure how to judge New: Add support to keep open streaming connections with Puma

@dentarg
Copy link
Member Author

dentarg commented Mar 4, 2023

That could probably be Fix instead of New?

@jkowens
Copy link
Member

jkowens commented Mar 4, 2023

@dentarg yeah I think you're right, this would be fine as a 3.0.6 release.

@dentarg dentarg changed the title 3.1.0 release 3.0.6 release Mar 4, 2023
@jkowens jkowens self-requested a review March 4, 2023 20:19
jkowens
jkowens approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@jkowens jkowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @dentarg!

@olleolleolle
Copy link
Member

Nice!

@dentarg dentarg force-pushed the bump-version branch 2 times, most recently from 23d9727 to cb2ea5a Compare March 5, 2023 15:34
@jkowens
Copy link
Member

jkowens commented Mar 7, 2023

@dentarg it looks like you should be able to cut a release to rubygems. Are you all good to do that?

@dentarg
Copy link
Member Author

dentarg commented Mar 7, 2023

I'm gonna study the rake tasks before I do it :) Hope to get to it later in the week.

@dentarg
Copy link
Member Author

dentarg commented Mar 13, 2023

@jkowens @zzak Looks like I didn't get access 😬 😇 Do you mind giving it again?

@jkowens
Copy link
Member

jkowens commented Mar 13, 2023

@dentarg I see you in pending status for these gems. Did you get an email invitation?

@dentarg
Copy link
Member Author

dentarg commented Mar 13, 2023

@jkowens got it!

@zzak
Copy link
Member

zzak commented Mar 13, 2023

@dentarg There is a guide here, hopefully it helps! Feel free to modify it and the process to your liking:
https://github.com/sinatra/sinatra/blob/main/RELEASING.md

Thanks for your contribution and congrats on your first release!

@dentarg
Copy link
Member Author

dentarg commented Apr 11, 2023

Yeah the git push in the release task wont work with our protected main branch (maybe what caused #1882?)

sinatra/Rakefile

Lines 194 to 211 in fb76534

desc 'Commits the version to github repository'
task :commit_version do
%w[
lib/sinatra
sinatra-contrib/lib/sinatra/contrib
rack-protection/lib/rack/protection
].each do |path|
path = File.join(path, 'version.rb')
File.write(path, File.read(path).sub(/VERSION = '(.+?)'/, "VERSION = '#{source_version}'"))
end
sh <<-SH
git commit --allow-empty -a -m '#{source_version} release' &&
git tag -s v#{source_version} -m '#{source_version} release' &&
git push && (git push origin || true) &&
git push --tags && (git push origin --tags || true)
SH
end

Good thing this branch has done the necessary changes :) I'll merge and build and push the packages

@dentarg dentarg merged commit 516ee3b into sinatra:main Apr 11, 2023
@dentarg dentarg deleted the bump-version branch April 11, 2023 15:22
@olleolleolle
Copy link
Member

@dentarg THANK YOU for pushing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowens jkowens jkowens approved these changes

@zzak zzak zzak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sinatra 3.0.5 on Rubygems has wrong version in version.rb
4 participants
@dentarg @jkowens @olleolleolle @zzak