Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash in uri helper on Integer input #1890

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Feb 26, 2023

I hope this makes sense, WDYT @sinatra/sinatras-helpers?

Close #1889

@jkowens
Copy link
Member

jkowens commented Feb 26, 2023

LGTM 👍

Copy link
Member

@epergo epergo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dentarg dentarg merged commit 892cbeb into sinatra:master Feb 26, 2023
@dentarg dentarg deleted the uri-fix branch February 26, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError - undefined method '=~' for 1:Integer
3 participants