-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add back a rack-protection.rb file #1814
Conversation
In order to keep compat with earlier files, this wrapper file is needed. See omniauth/omniauth#1089
Thanks for the quick action, @olleolleolle! |
This is similar to rack/rack-session#8 |
@dentarg Appreciate the sleuthing, the consuming gem had it a bit wrong the whole time. Them requiring rack/protection would be the fix. But, then again, we could be nice to the world at large, not forcing change upon them. |
@dentarg not all dependencies are auto-loaded through the Gemfile; a gem that uses rack-protection will have to use |
Yes, but it's different in the sense that there was a |
Thanks @olleolleolle. It looks like the test failures are due to breaking changes in Haml 6. I wonder if we should lock that to version 5 in our sinatra-contrib dev dependencies for now? I'm not exactly sure to do with that one. Haml::Buffer was removed. |
In order to keep compat with earlier files, this wrapper file is needed.
See omniauth/omniauth#1089
This is a reaction to #1537 (comment) - thanks @mvz !