Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify 'Using Sessions' section in README.ja.md to follow #1187 #1731

Merged

Conversation

shu-i-chi
Copy link
Contributor

I Modified 'Using Sessions' section in README.ja.md.
That section currently be of an older README.md version than of #1187.

Modified points

  • Added 3 subsections under the 'セッションの使用' ('Using Sessions') section
    • New: 'セッション秘密鍵のセキュリティ' ('Session Secret Security'), 'セッションコンフィグ' ('Session Config')
    • Moved: 'セッションミドルウェアの選択' ('Choosing Your Own Session Middleware')
  • Renamed 'セッションミドルウェアの選択' to '自分で選んだセッションミドルウェアを使う'
  • Replaced 'クッキー' with 'Cookie'
  • Added link to '攻撃防御に対する設定' ('Configuring attack protection') in the last sentence of 'セッションの使用' ('Using Sessions') section

Concerns

  • I'm not a crypto expert, so my translation may contain some misunderstanding
  • Renaming 'セッションミドルウェアの選択' may not be good

@jkowens jkowens merged commit 7ae1027 into sinatra:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants