Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small CI improvements #1703

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Small CI improvements #1703

merged 2 commits into from
Jun 2, 2021

Conversation

walro
Copy link
Contributor

@walro walro commented May 31, 2021 •
edited
Loading

  • Disable fast-fail so that we can feedback for all versions in the matrix, even if a specific version fails
  • Run the test workflow for all branches, this is useful when you want test feedback without having to open a PR

walro added 2 commits May 31, 2021 09:51
@walro
Disable fast-fail
9ce6a98 
Since we test against multiple versions of Ruby it makes sense to allow all Rubies to finish, regardless of fails for specific versions.
@walro
Run test workflow for all branches
d32c18e
@walro walro mentioned this pull request May 31, 2021
Merged
@epergo
Copy link
Member

epergo commented May 31, 2021

Run the test workflow for all branches, this is useful when you want test feedback without having to open a PR

Not sure about this but, isn't that option only valid for this repository? So only people with push rights here could benefit from it.

@walro
Copy link
Contributor Author

walro commented May 31, 2021

Not sure about this but, isn't that option only valid for this repository?

I think it's correct. Prior to the change, pushing a branch on a forked repository wouldn't trigger the test workflow.

@walro
Copy link
Contributor Author

walro commented May 31, 2021

I tested:

  • A commit in a branch based on current master: walro@e0eb1b5 (no workflow runs)
  • A commit in a branch based on this PR: walro@5a8b5d9 (workflow runs)

@epergo
Copy link
Member

epergo commented May 31, 2021

You are right! Thanks for the explanation 🙇‍♂️

@walro
Copy link
Contributor Author

walro commented Jun 1, 2021

Ah continue-on-error for a job still reports back failed status (I should have noticed this in my fork, sorry! 🤦). Have to change to the step scoped version but seeing we fail quite early, while installing gems, for ruby-head I am not entirely sure how to structure it right now.

Meanwhile, I will drop the commits regarding continue-on-error here and see if I can come up with something better for allow failures.

@walro walro force-pushed the ci-improvements branch from 6552bae to d32c18e Compare June 1, 2021 07:02
@walro walro changed the title CI improvements Small CI improvements Jun 1, 2021
@jkowens jkowens merged commit c33c2b1 into sinatra:master Jun 2, 2021
@walro walro deleted the ci-improvements branch June 2, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epergo epergo epergo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walro @epergo @jkowens