Set 2.6 as minimum ruby version for Sinatra 3 #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epergo
commented
May 21, 2021
| @@ -1,11 +1,4 @@ | |||
| # frozen_string_literal: true | |||
| $stderr.puts <<EOF if !Hash.method_defined?(:slice) && !$LOAD_PATH.grep(%r{gems/activesupport}).empty? && ENV['SINATRA_ACTIVESUPPORT_WARNING'] != 'false' | |||
There was a problem hiding this comment.
Hash#slice was added in Ruby 2.5 so this if is going to be false always.
|
I like this suggestion 👍 |
olleolleolle
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
A thorough and careful update! Thanks, @epergo!
(Any RuboCop configuration that could get an update, too.)
namusyaka
approved these changes
Sep 11, 2021
|
@namusyaka Do you feel ready to merge this? |
jkowens
pushed a commit
that referenced
this pull request
Oct 4, 2021
* Run tests for Ruby versions >= 2.6 * Remove not needed checks for methods defined * Set required_ruby_version to >= 2.6 * Update READMEs with new Ruby versions
jkowens
pushed a commit
that referenced
this pull request
Oct 4, 2021
* Run tests for Ruby versions >= 2.6 * Remove not needed checks for methods defined * Set required_ruby_version to >= 2.6 * Update READMEs with new Ruby versions
jkowens
pushed a commit
that referenced
this pull request
Oct 4, 2021
* Run tests for Ruby versions >= 2.6 * Remove not needed checks for methods defined * Set required_ruby_version to >= 2.6 * Update READMEs with new Ruby versions
jkowens
pushed a commit
that referenced
this pull request
Feb 2, 2022
* Run tests for Ruby versions >= 2.6 * Remove not needed checks for methods defined * Set required_ruby_version to >= 2.6 * Update READMEs with new Ruby versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have an
unstablebranch I think we can start doing these kind of changes. Ruby 2.5 support was dropped last March so I think that for the release of Sinatra 3.0 we could set the required minimum ruby version to 2.6 which will have support until March 2022.I have cleaned up the
indifferent_hashimplementation because we had a lot of conditionals to check if thehashimplementation of the installed ruby version had certain methods or not.WDYT?