switch ci from travis to actions #1691
Merged
+44
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namusyaka
commented
Apr 17, 2021
.github/workflows/test.yml
Outdated
| - name: Run tests | ||
| run: ./.actions.sh | ||
|
|
||
| # TODO(zzak, rkh): Add slack notification. |
There was a problem hiding this comment.
@zzak Probably we need to set up an integration with slack but I don't have a permission to generate a token on slack. Could you work on this?
|
Note that we should also update a status badge after merging this PR. |
dentarg
reviewed
Apr 17, 2021
olleolleolle
approved these changes
Apr 17, 2021
zzak
approved these changes
Apr 17, 2021
rkh
approved these changes
Apr 21, 2021
|
@namusyaka I've added the slack notification, but I think we may want to tweak it and possibly only run on |
|
+1 on changing the default branch to main. |
| @@ -5,14 +5,14 @@ echo "Running sinatra tests..." | |||
| bundle exec rake | |||
|
|
|||
| echo "Running sinatra-contrib tests..." | |||
| export BUILDIR=$TRAVIS_BUILD_DIR/sinatra-contrib | |||
| export BUILDIR=$GITHUB_WORKSPACE/sinatra-contrib | |||
There was a problem hiding this comment.
require 'sinatra'
get '/frank-says' do
'Put this in your pipe & smoke it!'
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.