Fix broken origin_whitelist option #1641 #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! @namusyaka would you be able to cut a patch release with this fix? |
|
Before cutting a new patch release, I would love to automate the process. I don't want to cut a new release manually again and again. |
|
@namusyaka / @jkowens I completely understand the wanting to automate the process, so if that's still a work in progress then great! This has been merged for nearly a year though, so I'm wondering if there's any plans on cutting a release with this change? |
|
@kmiller-stripe I'm disheartened with the state of Sinatra as well. I am not able to cut releases, I hope we see one sometime soon. cc: @sinatra/sinatras-helpers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug #1641