Avoid TypeError when params contain a key without a value on Ruby < 2.4
#1517
Conversation
|
This ought to go green when rebased atop #1513 |
| ## Unreleased | ||
|
|
||
| * Avoid `TypeError` when params contain a key without a value on Ruby < 2.4 [#1516](https://github.com/sinatra/sinatra/pull/1516) by Samuel Giddins | ||
|
|
There was a problem hiding this comment.
You don't need to update CHANGELOG.md
There was a problem hiding this comment.
The contributing.md said it made it easier to do releases when PRs included changelog entries 😉
There was a problem hiding this comment.
The changelog entry will automatically be generated by the release script: #1515
contributing.md will also be updated at the same time.
There was a problem hiding this comment.
https://github.com/sinatra/sinatra/blob/master/CONTRIBUTING.md#have-a-patch #4 says to update the changelog, I was just following the instructions 🤷
There was a problem hiding this comment.
@segiddins Yes, I apologize if confusing.
But as I said earlier, the contents of contributing.md will be updated soon.
Do you want to keep your own changelog entry so much?
If not, please remove the entry from changelog.
There was a problem hiding this comment.
agh, I was trying to figure out which PR it would be before opening it
namusyaka
changed the title
TypeError when params contain a key without a value on Ruby < 2.4
|
Just realized it doesn't cover one other case. When the parameter is while in >=2.4 And yet in JSON body payloads there can be a |
|
@RaVbaker do you have a repro for the issue? I think it is better to open up a new issue than commenting here |
|
@RaVbaker Good catch, I'll work on the issue soon |
Fixes #1514