Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Sinatra::Contrib dependency updates. Fixes #1207" #1410

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

namusyaka
Copy link
Member

Reverts #1208

@zzak zzak merged commit 5074c1e into master Mar 19, 2018
@zzak zzak deleted the revert-1208-contrib-deps branch March 19, 2018 01:57
@marcandre
Copy link
Contributor

Hi! What is the purpose of this PR?
(backports author here...)
Please avoid calling require 'backports' and instead require the needed backports individually.
In the case of Sinatra, I don't think there are any being used though.

@namusyaka
Copy link
Member Author

@marcandre The purpose of this PR is to revert #1208 as described.
As a matter of fact, you can say that your point is correct, but I think that you should rollback this change according to git's workflow.

@namusyaka
Copy link
Member Author

@marcandre I have just sent a PR to lock the version of the backports gem. As backports features, try and underscore have been used in sinatra-contrib.

@marcandre
Copy link
Contributor

try and underscore are not really backports, they are part of ActiveSupport
Would you consider instead requiring them from ActiveSupport instead? Having those in backports was a mistake, even when they used to not be available independently.

Otherwise, at the very least, do not require the whole suite of backports, but just those that are required. I can provide a PR if need be.

@marcandre marcandre mentioned this pull request Apr 15, 2018
@dentarg
Copy link
Member

dentarg commented Apr 24, 2018

@namusyaka what was the reason to revert #1208?

@namusyaka
Copy link
Member Author

@dentarg See #1208 (comment)
The change potentially breaks backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants