sinatra-namespace: Allow for set :<engine>
#1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is neat, thank you for the patch! Let's consider it for after a 2.0 release is made 🙇♂️ |
|
Could you add a spec for testing this behavior? |
|
I don't even know where to begin with that. I'll try, though. |
namusyaka
reviewed
Mar 20, 2017
| :erb, :haml, :builder, :nokogiri, :sass, :scss, :less, :liquid, :markdown, | ||
| :textile, :rdoc, :asciidoc, :radius, :markaby, :rabl, :slim, :creole, | ||
| :mediawiki, :coffee, :stylus, :yajl, :wlang | ||
| ] |
There was a problem hiding this comment.
Allowed keys should be defined as a constant.
There was a problem hiding this comment.
@mkaito Example constant names: ALLOWED_RENDER_ENGINE_KEYS, RENDER_ENGINE_NAMES, et cetera.
|
Here's a spec which explains the behaviour: diff --git a/sinatra-contrib/spec/namespace_spec.rb b/sinatra-contrib/spec/namespace_spec.rb
index 15381560..be06370a 100644
--- a/sinatra-contrib/spec/namespace_spec.rb
+++ b/sinatra-contrib/spec/namespace_spec.rb
@@ -818,5 +818,15 @@ describe Sinatra::Namespace do
get '/foo-bar'
expect(last_response.body).to eq('[:foo_bar]')
end
+
+ it 'forbids unknown engine settings' do
+ expect {
+ mock_app do
+ namespace '/foo' do
+ set :unknownsetting
+ end
+ end
+ }.to raise_error(ArgumentError, 'may not set unknownsetting')
+ end
end
end
|
|
@mkaito Hey, could you still address on this? If not, another patch is welcome. |
|
I... Completely forgot about this. Sorry. Yes, I'll look at it again as soon as I have a little time.
El 6 de marzo de 2018 13:13:14 GMT+00:00, namusyaka <notifications@github.com> escribió:
…
@mkaito Hey, could you still address on this? If not, another patch is
welcome.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1255 (comment)
--
Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.
|
|
Don't worry. Just listening to that reply is enough. |
jkowens
force-pushed
the
mkaito/namespace/allow-set-engine
branch
2 times, most recently
from
97170f2 to
7de9bd2
Compare
olleolleolle
approved these changes
Mar 19, 2020
This allows to set render engine options local to a namespace
jkowens
force-pushed
the
mkaito/namespace/allow-set-engine
branch
from
7de9bd2 to
8c53a79
Compare
|
@jkowens Hooray! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set render engine options local to a namespace
Fixes #1254