-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prepend instead of include for helpers. Fixes #1213 #1214
Conversation
See my comment on #1213 |
I did. 😄 This can wait. My only counterargument would be that there's never going to be a better time to break things, so if this makes sense, let's do it. The counterargument to that is that 2.0's already been in pre-release for ages and cramming things in at the end of the cycle isn't kosher. Anyway, I'm fine waiting, and if you are feeling like you'll never want to merge it, that's fine too. |
@mwpastore Please wait 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, but thanks. This looks reasonable to me.
You should also work on sinatra-namespace.
d55f238
to
8607e8a
Compare
Ouch, this broke a lot of things. Helpers are not overloaded like before. |
Yes. If a helper module uses included method, it doesn't work. |
Could use |
No description provided.