Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backports dependency from sinatra-contrib #1207

Closed
mwpastore opened this issue Nov 25, 2016 · 3 comments
Closed

Remove backports dependency from sinatra-contrib #1207

mwpastore opened this issue Nov 25, 2016 · 3 comments
Labels
has attached pr sinatra-contrib
Milestone
Beyond

Comments

@mwpastore
Copy link
Member

mwpastore commented Nov 25, 2016 •
edited
Loading

Now that the minimum Ruby version is 2.2 (.2 due to Rack 2), can we remove sinatra-contrib's dependency on backports? Tests pass on 2.2.2 without it with some light refactoring around String#underscore and Object#try.

Why is Rack::Test a runtime dependency and not a development dependency?

I've submitted a PR with these changes but wanted to see what "tribal knowledge" might be out there.
mwpastore added a commit to mwpastore/sinatra that referenced this issue Nov 25, 2016
@mwpastore
Sinatra::Contrib dependency updates. Fixes sinatra#1207
da03260 
* Remove backports
* Work around Object#try and String#underscore
* Make Rack::Test a development dependency
mwpastore added a commit to mwpastore/sinatra that referenced this issue Nov 26, 2016
@mwpastore
Sinatra::Contrib dependency updates. Fixes sinatra#1207
7ba7818 
* Remove backports
* Work around Object#try and String#underscore
* Make Rack::Test a development dependency
@zzak
Copy link
Member

zzak commented Dec 14, 2016

I think it's ok, but want to focus what limited time budget I have on shipping and will probably put this kind of stuff off until after the release.

@zzak zzak added this to the Beyond milestone Dec 14, 2016
@mwpastore mwpastore mentioned this issue Jan 13, 2017
Merged
@zzak zzak changed the title sinatra-contrib dependencies Remove backports dependency from sinatra-contrib Jan 14, 2017
@zzak
Copy link
Member

zzak commented Jan 14, 2017

#1208 resolves this

mwpastore added a commit to mwpastore/sinatra that referenced this issue Jan 14, 2017
@mwpastore
Sinatra::Contrib dependency updates. Fixes sinatra#1207
97102d5 
* Remove backports
* Work around Object#try and String#underscore
namusyaka added a commit that referenced this issue Mar 18, 2018
@namusyaka
Merge pull request #1208 from mwpastore/contrib-deps
045a05b 
Sinatra::Contrib dependency updates. Fixes #1207
namusyaka added a commit that referenced this issue Mar 19, 2018
@namusyaka
Revert "Sinatra::Contrib dependency updates. Fixes #1207"
08a10e6
zzak pushed a commit that referenced this issue Mar 19, 2018
@namusyaka
Revert "Sinatra::Contrib dependency updates. Fixes #1207" (#1410)
5074c1e
namusyaka pushed a commit that referenced this issue Mar 19, 2018
@mwpastore @namusyaka
Sinatra::Contrib dependency updates. Fixes #1207
3a78de8 
* Remove backports
* Work around Object#try and String#underscore
@namusyaka namusyaka reopened this Mar 19, 2018
@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Closed
@ChrisBAshton
Copy link

Can you close this issue please? #1208 has been merged 🎉

@jkowens jkowens closed this as completed Aug 24, 2019
jkowens pushed a commit that referenced this issue Mar 13, 2020
@namusyaka
Sinatra::Contrib dependency updates. Fixes #1207 (#1411)
8ddf4f9 
* Remove backports
* Work around Object#try and String#underscore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has attached pr sinatra-contrib
Projects
None yet
Milestone
Beyond
Development

Successfully merging a pull request may close this issue.

Bump sinatra from 14f86a8 to 5074c1e borja/herocalf
5 participants
@zzak @namusyaka @jkowens @ChrisBAshton @mwpastore