Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing guide #987

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Add contributing guide #987

merged 1 commit into from
Mar 24, 2015

Conversation

kytrinyx
Copy link
Contributor

This is essentially a straight copy from the documentation, but
I updated the list of available languages.

@kytrinyx kytrinyx force-pushed the contributing-guide branch from 4798ae9 to f5727b2 Compare March 24, 2015 03:43

## Need help?

The [Sinatra mailing list][https://groups.google.com/forum/#!forum/sinatrarb] has
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the link here be in parentheses ()? GitHub's rich-diff renderer doesn't seem to parse this properly.

Screenshot of the render: http://cl.ly/image/0r1G193o2E1f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that looks wrong. Let me check the old page that I ported as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I converted it from the old [ml] notation to the full link, before I realized how the [ml] thing worked. I'm switching that back now.

@kytrinyx kytrinyx force-pushed the contributing-guide branch from f5727b2 to d51d026 Compare March 24, 2015 04:12
This is essentially a straight copy from the documentation, but
I updated the list of available languages.
@kytrinyx kytrinyx force-pushed the contributing-guide branch from d51d026 to 2ea4612 Compare March 24, 2015 05:35
overview of the changes that go into each release, and gives credit
where credit is due. We make sure that the Changelog is up to date
before each release, and we always appreciate it when people make
it easier to get the release out the door.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a step about the Changelog. I'd welcome suggestions for improvements to the phrasing here.

zzak pushed a commit that referenced this pull request Mar 24, 2015
@zzak zzak merged commit 29c51d1 into master Mar 24, 2015
@zzak zzak deleted the contributing-guide branch March 24, 2015 05:41
zzak pushed a commit that referenced this pull request Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants