Make route params available during error handler (Fixes #860) #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kind of ugly, but I couldn't see a better way. One potential issue is that the splat and captures route params will be overwritten by the error handler. There's no way to change that without breaking backwards compatibility. We could potentially offer the route splat/captures under different param names, though.
|
I'm inclined to agree. It would be really nice to have those handy at that time! What would be the use-case for having them in the pattern-less before/after blocks? |
Personally, I've never run into a use case, since then I could usually use a pattern with the filter. People seem to assume it should work, see for instance #417. However, after giving this some thought, I don't think we should do it, since it would only work for after filters. |
|
Agreed, let's not go down that path. I'm happy with this PR as is. |
zzak
pushed a commit
that referenced
this pull request
Jan 31, 2016
Make route params available during error handler (Fixes #860)
zzak
pushed a commit
that referenced
this pull request
Jan 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of ugly, but I couldn't see a better way. One
potential issue is that the splat and captures route params
will be overwritten by the error handler. There's no way to
change that without breaking backwards compatibility. We
could potentially offer the route splat/captures under
different param names, though.