Use Sinatra::Runner In Integration Test #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I just met you, and this is crazy, but there's a conflict, so rebase, maybe? |
|
You have to merge the sinatra-contrib PR first, then point the sinatra Gemfile to the updated gem. 💋 |
New favourite git comment |
|
We can merge this once it is rebased, and |
|
Rebased and fixed in 80016d7 |
|
💋 |
|
@apotonick <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PR sinatra/sinatra-contrib#122 we now use
Sinatra::Runnerfor integration tests.Only problem is that we have a development dependency to
sinatra-contribbut @rkh promised to look into that.