Reel suppport #793
Reel suppport #793
Conversation
| @@ -1420,7 +1420,11 @@ def run!(options = {}, &block) | |||
| handler = detect_rack_handler | |||
| handler_name = handler.name.gsub(/.*::/, '') | |||
| server_settings = settings.respond_to?(:server_settings) ? settings.server_settings : {} | |||
| server_settings.merge!(:Port => port, :Host => bind) | |||
| if handler_name == 'Reel' | |||
| server_settings.merge!(:port => port, :host => bind) | |||
There was a problem hiding this comment.
This is because of this: https://github.com/celluloid/reel-rack/blob/master/lib/rack/handler/reel.rb#L7-L8
|
You were faster! I was digging the same thing! 👍 |
|
😉 |
|
Port/Host is the standard, shouldn't reel rather be adjusted? |
|
Yes, sure, that's what I thought. I'll send a pull request to reel-rack and then I'll update this pull request. |
|
I'll notify here when a new version of reel-rack gets released. |
|
Hah, just traced down the reel integration test failures only to see this PR 2 hours later, with the exact same changes. Won't open another PR then. Good job. :> |
|
So what's the status on this? |
|
@rkh It has been merged, but the new Reel release is not here yet. |
|
Pinged @tarcieri a few minutes ago on IRC, waiting for an answer and gem release. |
|
reel-rack 0.1.0 has been released with standard |
|
Thank you very much @tarcieri! |
|
I think we can't do anything about this yet because reel doesn't support Ruby 1.8, and we do: https://github.com/celluloid/reel-rack/blob/master/.travis.yml |
See discussions in #773 and #774.