Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test TestIndifferentHashBasics#test_default_object fails in ruby-head #2026

Closed
dentarg opened this issue Jul 10, 2024 · 0 comments · Fixed by #2028
Closed

Test TestIndifferentHashBasics#test_default_object fails in ruby-head #2026

dentarg opened this issue Jul 10, 2024 · 0 comments · Fixed by #2028
Labels
ci / testing

Comments

@dentarg
Copy link
Member

dentarg commented Jul 10, 2024

From https://github.com/sinatra/sinatra/actions/runs/9879363987/job/27285443163#step:5:234

Ruby version is ruby 3.4.0dev (2024-07-09T17:22:29Z :detached: 6f6aff56b1) [x86_64-linux]

  1) Error:
TestIndifferentHashBasics#test_default_object:
ArgumentError: unknown keywords: :a, "b"
    <internal:hash>:37:in 'initialize'
    test/indifferent_hash_test.rb:29:in 'Class#new'
    test/indifferent_hash_test.rb:29:in 'TestIndifferentHashBasics#test_default_object'
@ioquatix ioquatix mentioned this issue Jul 11, 2024
Merged
dentarg pushed a commit that referenced this issue Jul 11, 2024
@ioquatix
Fix warning about Hash construction. (#2028)
4def0aa 
Fixes <#2026>.

```
sinatra/test/indifferent_hash_test.rb:29: warning: Calling Hash.new with keyword arguments is deprecated and will be removed in Ruby 3.4; use Hash.new({ key: value }) instead
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warning about Hash construction. ioquatix/sinatra
1 participant
@dentarg