Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The header in version 3 is less user friendly #1813

Closed
DannyBen opened this issue Sep 26, 2022 · 7 comments · Fixed by #1818
Closed

The header in version 3 is less user friendly #1813

DannyBen opened this issue Sep 26, 2022 · 7 comments · Fixed by #1818

Comments

@DannyBen
Copy link

DannyBen commented Sep 26, 2022 •
edited
Loading

I noticed that the new header in version 3 prints a from <path> line, showing the full path of where puma was launched from...
Not sure what is the purpose of this, it is not in line with the rest of the header, which is user friendly, concise, and does not include debugging information.

I would love to see this line removed, it looks like a mistake.

== Sinatra (v3.0.0) has taken the stage on 3000 for production with backup from Puma
        from /home/vagrant/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/puma-5.6.5/lib/rack/handler/puma.rb:70:in `run'
Puma starting in single mode...
* Puma version: 5.6.5 (ruby 3.1.0-p0) ("Birdie's Version")
... trimmed ...
@jkowens
Copy link
Member

jkowens commented Sep 26, 2022

Hmm maybe this is due to the change from $stderr.puts to warn (another rubocop update):

sinatra/lib/sinatra/base.rb

Line 1573 in e521b60

warn "== Sinatra (v#{Sinatra::VERSION}) has taken the stage on #{port} for #{environment} with backup from #{handler_name}"

@olleolleolle @dentarg does that sound possible to you?

@olleolleolle
Copy link
Member

olleolleolle commented Sep 26, 2022 •
edited
Loading

Plausible, even!

Is this a place where that can be tested?
https://github.com/sinatra/sinatra/blob/master/test/server_test.rb#L79

@DannyBen
Copy link
Author

DannyBen commented Sep 26, 2022 •
edited
Loading

What's the rationale for this to become a warning? Seems like a misguided rubocop rule...

@jkowens
Copy link
Member

jkowens commented Sep 26, 2022

I'm trying to test locally. I'm seeing that extra file information even after reverting to $stderr.puts 😕

@jkowens
Copy link
Member

jkowens commented Sep 26, 2022

Oops nevermind! It does fix it, I forgot to bundle exec 🤦‍♂️

@jkowens jkowens mentioned this issue Sep 26, 2022
Merged
@jkowens
Copy link
Member

jkowens commented Sep 26, 2022

Fix released in v3.01.

@DannyBen
Copy link
Author

Wow, didn't expect such a speedy release. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert to using stderr.puts for start up message jkowens/sinatra
3 participants
@olleolleolle @jkowens @DannyBen