-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop thin support #1624
Comments
@namusyaka Hi |
I never managed to get streaming work with puma, only with thin. Worried. |
I guess the rainbows can handle the streaming feature. See #1627 |
May I propose to re-open this issue in order to link the update of documentation on different languages? |
@esparta I would suggest creating a new issue about the docs (easier to understand what's need to be done then) |
As I noted in sinatra/sinatra.github.com#274, we'll wait and see what happens around rack/thin for making a decision on what server should be choosed. This indicates there is a possibility of reverting #1627 partially (In any case the integration test with rainbows can be helpful). |
We'll use rainbows in our development environment, but I restored thin support in 342758a because of macournoyer/thin@b201525. |
After sinatra#1624 `thin` is still left in this block, which keeps it the most preferred server in regular Ruby. Let's remove it for real this time.
As per rack/rack@98d9cf5, it's time to drop the support for thin.
Does anyone want to take this issue?
The text was updated successfully, but these errors were encountered: