Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinatra::Contrib::ConfigFile should allow *.yaml #1563

Closed
namusyaka opened this issue Aug 23, 2019 · 2 comments
Closed

Sinatra::Contrib::ConfigFile should allow *.yaml #1563

namusyaka opened this issue Aug 23, 2019 · 2 comments
Labels
good first issue sinatra-contrib

Comments

@namusyaka
Copy link
Member

Currently it won't accept that, only .yml or .yml.erb.
Here is an error message:

Invalid config file type, use .yml or .yml.erb (Sinatra::ConfigFile::UnsupportedConfigType)

However, as you can see in kubernetes, .yaml is also known as a valid extension.

If you're interested in sending a patch to sinatra, feel free to submit a PR.
@EmersonManabuAraki
Copy link

EmersonManabuAraki commented Aug 26, 2019 •
edited
Loading

PR with the fix: #1564

@EmersonManabuAraki EmersonManabuAraki mentioned this issue Aug 26, 2019
Merged
namusyaka added a commit that referenced this issue Sep 6, 2019
@namusyaka
Merge pull request #1564 from EmersonManabuAraki/fix/allow-yaml-files
722353e 
Fix/allow yaml files for Issue #1563
@jkowens
Copy link
Member

jkowens commented Sep 9, 2019

Closed by #1564.

@jkowens jkowens closed this as completed Sep 9, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Mar 20, 2020
www/ruby-sinatra: update to 2.0.8.1
610f760 
Update ruby-sinatra to 2.0.8.1.


## 2.0.8.1 / 2020-01-02

* Allow multiple hashes to be passed in `merge` and `merge!` for `Sinatra::IndifferentHash` [#1572](sinatra/sinatra#1572) by Shota Iguchi

## 2.0.8 / 2020-01-01

* Lookup Tilt class for template engine without loading files [#1558](sinatra/sinatra#1558). Fixes [#1172](sinatra/sinatra#1172) by Jordan Owens

* Add request info in NotFound exception [#1566](sinatra/sinatra#1566) by Stefan Sundin

* Add `.yaml` support in `Sinatra::Contrib::ConfigFile` [#1564](sinatra/sinatra#1564). Fixes [#1563](sinatra/sinatra#1563) by Emerson Manabu Araki

* Remove only routing parameters from @params hash [#1569](sinatra/sinatra#1569). Fixes [#1567](sinatra/sinatra#1567) by Jordan Owens, Horacio

* Support `capture` and `content_for` with Hamlit [#1580](sinatra/sinatra#1580) by Takashi Kokubun

* Eliminate warnings of keyword parameter for Ruby 2.7.0 [#1581](sinatra/sinatra#1581) by Osamtimizer

## 2.0.7 / 2019-08-22

* Fix a regression [#1560](sinatra/sinatra#1560) by Kunpei Sakai

## 2.0.6 / 2019-08-21

* Fix an issue setting environment from command line option [#1547](sinatra/sinatra#1547), [#1554](sinatra/sinatra#1554) by Jordan Owens, Kunpei Sakai

* Support pandoc as a new markdown renderer [#1533](sinatra/sinatra#1533) by Vasiliy

* Remove outdated code for tilt 1.x [#1532](sinatra/sinatra#1532) by Vasiliy

* Remove an extra logic for `force_encoding` [#1527](sinatra/sinatra#1527) by Jordan Owens

* Avoid multiple errors even if `params` contains special values [#1526](sinatra/sinatra#1527) by Kunpei Sakai

* Support `bundler/inline` with `require 'sinatra'` integration [#1520](sinatra/sinatra#1520) by Kunpei Sakai

* Avoid `TypeError` when params contain a key without a value on Ruby < 2.4 [#1516](sinatra/sinatra#1516) by Samuel Giddins

* Improve development support and documentation and source code by  Olle Jonsson, Basavanagowda Kanur, Yuki MINAMIYA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue sinatra-contrib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@namusyaka @jkowens @EmersonManabuAraki