Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinatra 2.0.3 introduces new active_support dependency #1451

Closed
KrauseFx opened this issue Jun 19, 2018 · 2 comments
Closed

sinatra 2.0.3 introduces new active_support dependency #1451

KrauseFx opened this issue Jun 19, 2018 · 2 comments

Comments

@KrauseFx
Copy link

Hey sinatra contributors,

With sinatra 2.0.3, we now have active_support as a dependency, as introduced with #1442. I didn't dive into the code base yet on why this is necessary, so I wanted to check here first:

  1. Was this change intentional?
  2. Is there a good alternative to avoid adding a new dependency to the graph? On the first look it seems like we're only using active_support/core_ext/object/try.rb and backports/rails/string

Context: we're using sinatra for the new fastlane.ci project.

@jkowens
Copy link
Member

jkowens commented Jun 19, 2018

There is some discussion about this subject here: #1448

@KrauseFx
Copy link
Author

Perfect, thanks @jkowens, I only searched for issues, not for PRs, thanks, will close this now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants