Override Rack::ShowExceptions#pretty to set custom template #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overrides Rack::ShowExceptions::TEMPLATE without affecting other Rack apps that are mounted alongside Sinatra.
namusyaka
approved these changes
Jan 13, 2018
There was a problem hiding this comment.
This looks good to me.
In my opinion, if the rack pr will be accepted, it means that the way is standard for defining custom template in any sub frameworks, but our current issue should be considered separately from that.
I also thought about defining the Sinatra::ShowException class as a completely unique class apart from those of rack, like ActionDispatch::ShowExceptions
However our exception handling depends on env['rack.errors'], so at least at the moment we should inherit and extend Rack :: ShowExceptions.
|
@jkowens I'm going to merge this PR, thanks for your patch. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overrides Rack::ShowExceptions::TEMPLATE without affecting other Rack apps that are mounted alongside Sinatra. Resolves #1376.
I would like to revisit this if rack/rack/pull/1223 gets merged 😜