avoid prefix duplication #1322
Merged
avoid prefix duplication #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this branch works. LGTM. Gemfile: github 'namusyaka/sinatra', branch: 'fix-1310' do
gem 'sinatra'
gem 'sinatra-contrib'
endapp.rb: require 'rubygems'
require 'bundler/setup'
require 'sinatra'
require 'sinatra/contrib'
require 'json'
BOOKS = {
1 => {name: 'The Lord of the Rings'},
2 => {name: 'The Chronicles of Narnia'},
3 => {name: 'Harry Potter'},
}
namespace '/api' do
namespace '/v1' do
namespace '/books' do
get do
body JSON.dump(BOOKS)
end
end
end
endCurl: curl -X GET http://localhost:4567/api/v1/booksCurl resp: {"1":{"name":"The Lord of the Rings"},"2":{"name":"The Chronicles of Narnia"},"3":{"name":"Harry Potter"}} |
zzak
reviewed
Jul 8, 2017
| @@ -319,7 +319,6 @@ def compile(pattern, conditions, default_pattern = nil) | |||
| end | |||
| base_pattern, base_conditions = @pattern, @conditions | |||
| pattern ||= default_pattern | |||
| base_pattern ||= base.pattern if base.respond_to? :pattern | |||
| base_conditions ||= base.conditions if base.respond_to? :conditions | |||
There was a problem hiding this comment.
in this case, don't we also set base_conditions above too?
There was a problem hiding this comment.
Ah, yes. However, it should be treated as a different issue.
Briefly, that conditions has not been permanently satisfied, so I deleted it as new commit.
the `base` does not respond to `conditions` permanently.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1310
@aren55555 @mencargo @zzak Could you confirm this?