Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase: Make #has_key? also indifferent in access #1262

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Rebase: Make #has_key? also indifferent in access #1262

merged 1 commit into from
Mar 7, 2017

Conversation

JonMidhir
Copy link
Contributor

Rebases #1169 by @singpolyma without the docs update, as it's part of the Sinatra 2.0 milestone.

From original PR:

With the old strategy for indifferent access, one still had to use the
correct one of String or Symbol to ask if params#has_key? -- this fixes
that so that access is more truly indifferent.

@singpolyma @JonMidhir
Make #has_key? also indifferent in access
ab69422 
With the old strategy for indifferent access, one still had to use the
correct one of String or Symbol to ask if params#has_key? -- this fixes
that so that access is more truly indifferent.
@zzak
Copy link
Member

zzak commented Mar 7, 2017

/cc #1216

@zzak zzak merged commit 379e360 into sinatra:master Mar 7, 2017
@zzak zzak mentioned this pull request Mar 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonMidhir @zzak @singpolyma