-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture exception messages of raised NotFound and BadRequest #1210
Conversation
@mwpastore Could you rebase please? |
cc #1216 |
fd8ddc9
to
1d3d9ef
Compare
@zzak I've noticed that we are reimplementing a lot of Rack::Response in Sinatra::Base::Helpers. I'm guessing this is due to the fact that Rack has improved over time to include more and more functionality. Can we use the delegation pattern to clean this up? Take a look at what I've done here. We can remove a bunch of tests, too, if we think this is a good idea. There's a lot going on in this commit all of a sudden so let me know if you'd like me to break it up. |
@mwpastore I'm not against using delegators but this close to a release -- I want to make sure this won't affect any behavior or have performance impact. With that said, something like this could be investigated after the release is made. |
1d3d9ef
to
711c320
Compare
Okay, I pulled the gnarly stuff out into a separate branch for later perusal and refocused this PR back to its original purpose. Let me know if you want to see any other changes! |
For a second, I thought "body" was the body of the request, which would probably not be a good idea to print. So can you change the wording from "body" -> "exception message"? |
711c320
to
0393f55
Compare
How's that? |
No description provided.