Modernize Rack::Protection::ContentSecurityPolicy #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds complete set of directives that are currently supported by browsers that support CSP Level 2 and Level 3 (draft). Also supports directives that don't take any arguments. The directives in the content security policy output are now sorted.
|
The Travis CI build failures above are unrelated to these commits. From the build logs: https://travis-ci.org/sinatra/sinatra/builds/173822296 |
|
Travis failing is related to #1199 |
|
This will be succeed because g++-4.8 is now available on ubuntu-trusty. |
esparta
reviewed
Nov 20, 2016
| img_src: "'self'", style_src: "'self'", | ||
| connect_src: "'self'", report_only: false | ||
|
|
||
| DIRECTIVES = [:base_uri, :child_src, :connect_src, :default_src, |
There was a problem hiding this comment.
how about use %i(..) for the list directives ?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1201 Modernizes Rack::Protection::ContentSecurityPolicy to support current CSP2 and CSP3 directives.
Issue #1200 Fixes a minor security warning on
bundle installin a fresh repo.Removes inline docs which were incomplete and insufficient for what is now
quite complex in CSP2 and CSP3. Adds additional current links to excellent
doc resources and tools.