Use Mustermann for patterns #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing on JRuby atm. |
|
The tests are passing if I run one file at a time. I ran the Is this because we are using a pre-release jRuby version for the test? I see this in travis logs:
|
|
Build is green with latest JRuby (9.1.0.0) |
|
Awesome 🎉 |
|
👏👏👏👏 |
|
🎉 |
|
🚀 |
|
@rkh Should we move mustermann from your personal project to Sinatra organization? |
|
@namusyaka done |
|
@rkh Great! Thank you! |
vipulnsward
added a commit
to vipulnsward/sinatra-contrib
that referenced
this pull request
Jul 7, 2016
…that replaced normal route parsing to use Mustermann in sinatra/sinatra#1086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Sinatra use Mustermann. It also updates the pattern to what I'd like the Sinatra 2.0 syntax to be, it is generally compatible with the old syntax.
This will also lead to more meaningful errors on broken patterns.
Advanced Mustermann features are not yet exposed.