Enable frozen_string_literal feature. #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall-lee
force-pushed
the
frozen_string_literal
branch
from
47aa552 to
6ddc73c
Compare
|
The pedantic side of me tells me this PR might be better suited for the |
|
@kgrz thank you for your response!
What can I do for this? |
|
I'm against merging this for 1.4.x because it may introduce subtle bugs that will be hard to trackdown / fix. |
|
@marshall-lee Could you possibly rebase? Thanks |
|
@zzak sure! |
marshall-lee
force-pushed
the
frozen_string_literal
branch
from
6ddc73c to
56a6141
Compare
|
Rebased build seems to be okay |
zzak
pushed a commit
that referenced
this pull request
Feb 2, 2016
Enable frozen_string_literal feature.
|
@marshall-lee Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
'literal'.freeze'fever not affected Sinatra and it's cool because now we have a better option:frozen_string_literalpragma introduced in Ruby 2.3.0!