Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and polish the Chinese translation (README.zh.md) #1069

Merged
merged 1 commit into from
Jan 24, 2016

Conversation

fighterleslie
Copy link
Contributor

The original Chinese translation was rather outdated. This pull request aims at updating it to comply with the current English version (README.md). Many sentences are also rephrased to improve readability.

@codeworm96
Copy link
Contributor

Great work! But there are some little problems:

  1. Some links in the Table of Contents are broken
  2. Some headings in the '可选的模板语言' section are not translated
  3. Markdown style breaks near the '可选的设置' section
    Could you fix these problem?

@kgrz
Copy link
Member

kgrz commented Jan 21, 2016

@fighterleslie There also have been some updates to the URL in general across the entire README.md (via #1072) Would be great if you could go through necessary changes based on it.

@fighterleslie
Copy link
Contributor Author

Hi @codeworm96 Thanks for the review. 😄

Some links in the Table of Contents are broken

Broken links in TOC have been fixed and tested.

Some headings in the '可选的模板语言' section are not translated

Translated.

Markdown style breaks near the '可选的设置' section

Fixed.

@kgrz URLs have been updated as per #1072

@codeworm96
Copy link
Contributor

@fighterleslie Well done.

zzak pushed a commit that referenced this pull request Jan 24, 2016
Update and polish the Chinese translation (README.zh.md)
@zzak zzak merged commit 5c4abbc into sinatra:master Jan 24, 2016
@fighterleslie fighterleslie deleted the README.zh branch January 25, 2016 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants